Bug in __init()__

[martinowitsch]

There seems to be a bug in line 41 in the __init()__.py file.

The join() function will crash:
raise RuntimeError("Blosc2 library not found. " f"I looked for \"{', '.join(blosc2_search_paths)}\"")

If the list blosc2_search_paths conatins a 'None', i.e.:
['libblosc2.dll', 'c:\Somewhere\libblosc2.dll', None]

Traceback (most recent call last):
  File "c:\IniTest.py", line 34, in <module>
    f"I looked for \"{', '.join(blosc2_search_paths)}\"")
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: sequence item 2: expected str instance, NoneType found

This may happen, when the list is generated in line 27:

blosc2_search_paths = [blosc2_lib_hardcoded,
                       os.path.join(current_dir, blosc2_lib_hardcoded),
                       find_library("blosc2")]

And the function find_library("blosc2") returns 'None' if no lib was found.

I've encountered this error while generating an executable via PyInstaller and forgot to link the libblosc2.dll.

[avalentino]

Dear @martinowitsch
thanks a lot for reporting.
It seems that you made already a very good analysis!
Would you like to submit a PR to fix this issue?

[martinowitsch]

Sure, however since I am new to git, whats a PR? 😄
I would propose to typecast the return value of find_library("blosc2") call in line 43:
str(find_library("blosc2"))

[avalentino]

Thanks @martinowitsch
PRs are Pull Requests
It is the common way to propose changes to project managed by other people.
The workflow is quite simple:

• you fork the repository for which you want to propose a change
• in the forked repository you create a dedicated git branch
• edit the code to implement the changes you with
• commit and publish the code on your fork
• create the pull request using the button that appears in the GitHub web interface (in your fork)

Once the PR is created the rest suite is automatically run
At this stage we can check and approve you changes vefore merging into the main project.

Please let me know if you need more assistance.

[RitikaxShakya]

May I know if this issue is taken? if not may i take this issue?

[avalentino]

Hi @RitikaxShakya
you are more than welcome to take in charge this issue.
Thanks a lot

[RitikaxShakya]

Yes i would like to pick this issue.