POSIX-style transparent SoftLinks #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (to make etc. work on target nodes)
…ted and working for Array and Table targets. TODO: tab autocompletion from target node's attributes?
alimuldal
force-pushed
the
enhanced_softlinks
branch
from
c70f914
to
f89b5e0
Compare
|
Thanks @alimuldal it looks good. |
… has no attribute '<name>')
…softlink-->group.child.attribute
avalentino
added a commit
that referenced
this pull request
Nov 15, 2014
alimuldal
pushed a commit
to alimuldal/PyTables
that referenced
this pull request
Apr 1, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find the existing
SoftLinkclass to be a bit clunky, in that you have to call the link object in order to dereference it before you can access the attributes of the node it's pointing to. This is quite different to how softlinks usually behave, e.g. POSIX-style symbolic links which you can read and write to transparently, just as if you were operating on the target file itself. Making softlinks expose the same attributes and methods as the nodes they target removes the need to include extra boilerplate code when passing them to functions that would normally accept arrays, tables etc.Here's a first attempt to provide this sort of functionality - I'm sure there may be more elegant approaches, and I'd like to hear your feedback.