Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockers for GPU testing #21

Merged
merged 9 commits into from Jan 3, 2022
Merged

Dockers for GPU testing #21

merged 9 commits into from Jan 3, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 2, 2022

Before submitting

  • Was this discussed/approved via a GitHub issue? (no need for typos and docs improvements)
  • Did you create/update your configuration file?
  • Did you add your config to CI - GitHub action and Azure pipeline?
  • Are all integration tests passing?

What does this PR do? [optional]

creating own docker image with PyTorch and sudo

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added enhancement New feature or request CI/CD Continues Integration / delivery labels Jan 2, 2022
@Borda Borda requested a review from SeanNaren January 2, 2022 21:55
@codecov
Copy link

codecov bot commented Jan 2, 2022

Codecov Report

Merging #21 (9d1b13d) into main (73e0dff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #21   +/-   ##
=======================================
  Coverage   85.09%   85.09%           
=======================================
  Files           2        2           
  Lines         208      208           
=======================================
  Hits          177      177           
  Misses         31       31           
Flag Coverage Δ
Linux 85.09% <ø> (ø)
Windows 85.09% <ø> (ø)
cpu 85.09% <ø> (ø)
macOS 85.09% <ø> (ø)
pytest 85.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73e0dff...9d1b13d. Read the comment docs.

@Borda Borda requested a review from a team January 2, 2022 22:19
@Borda Borda enabled auto-merge (squash) January 2, 2022 22:25
@Borda Borda requested a review from a team January 3, 2022 08:01
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

.github/workflows/dockers.yml Show resolved Hide resolved
.github/workflows/dockers.yml Show resolved Hide resolved
@Borda Borda merged commit 2dbcaa9 into main Jan 3, 2022
@Borda Borda deleted the dockers branch January 3, 2022 09:01
@Borda
Copy link
Member Author

Borda commented Jan 3, 2022

nit:

sorry, it was an automatic merge... :/

@rohitgr7
Copy link
Contributor

rohitgr7 commented Jan 3, 2022

nit:

sorry, it was an automatic merge... :/

I think you should configure the no-merge until all conversations are resolved plugin here.

@Borda
Copy link
Member Author

Borda commented Jan 3, 2022

I think you should configure the no-merge until all conversations are resolved plugin here.

it was already set, so probably something fishy about the rule...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Continues Integration / delivery enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants