Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flash CI #41

Merged
merged 9 commits into from May 6, 2022
Merged

Fix flash CI #41

merged 9 commits into from May 6, 2022

Conversation

ethanwharris
Copy link
Member

@ethanwharris ethanwharris commented Mar 1, 2022

Before submitting

  • Was this discussed/approved via a GitHub issue? (no need for typos and docs improvements)
  • Did you create/update your configuration file?
  • Did you set runtimes in config for GitHub action integration?
  • Did you add your config to CI in Azure pipeline (only projects with 100+ GitHub stars)?
  • Are all integration tests passing?

What does this PR do? [optional]

Fixes # (issue) [add a link to the created issue in your repository if any]
OR link your project for clarity.

Did you have fun?

Make sure you had fun coding 馃檭

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #41 (e22b502) into main (ab22468) will not change coverage.
The diff coverage is n/a.

@@        Coverage Diff         @@
##           main   #41   +/-   ##
==================================
  Coverage    87%   87%           
==================================
  Files         2     2           
  Lines       209   209           
==================================
  Hits        181   181           
  Misses       28    28           

@Borda
Copy link
Member

Borda commented Mar 8, 2022

@ethanwharris seems it is still breaking...

@Borda Borda added the bug / fix Something isn't working label Mar 9, 2022
@ethanwharris
Copy link
Member Author

@Borda Should all be passing now 馃槂

@Borda
Copy link
Member

Borda commented Mar 25, 2022

Should all be passing now

seems to be failing for an unrelated reason - pytest/flake8

UPDATE: seems there is some problem sooner with installation :/

@Borda Borda enabled auto-merge (squash) May 6, 2022 00:39
@Borda Borda disabled auto-merge May 6, 2022 01:29
@Borda Borda merged commit 2965f3b into main May 6, 2022
@Borda Borda deleted the bugfix/flash_ci branch May 6, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants