New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
First pass at README changes #6
Conversation
@SeanNaren any updates on the logo ? |
@SeanNaren fyi, #10 is adding several discussed features 馃惏 |
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2aab656
to
a4d0073
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after #6 (comment)
Should be good to go @Borda I'd add a minimal template.yaml with things commented out that are unnecessary for a normal repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks interesting!
- "MyUsername/my_project-master.yaml" | ||
``` | ||
|
||
5. Add the responsible person(s) to [CODEOWNERS](.github/CODEOWNERS) for your organization folder or just the project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discovered that this won't do anything special unless the user is actually part of the repo (with write access).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, but they are at least automatically added for the review..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No they are not, that's what I'm saying. See example here:
PR Lightning-AI/pytorch-lightning#10369
Codeowners: https://github.com/PyTorchLightning/pytorch-lightning/blob/85d7c4dce4661ef5c12fcbd0d9e164ffc371e1af/.github/CODEOWNERS#L28-L30
The people you choose as code owners must have write permissions for the repository. When the code owner is a team, that team must be visible and it must have write permissions, even if all the individual members of the team already have write permissions directly, through organization membership, or through another team membership.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, co we would need to come with another solution... :/
Co-authored-by: Adrian W盲lchli <aedu.waelchli@gmail.com>
Before submitting
TODO:
What does this PR do? [optional]
Fixes # (issue).
Did you have fun?
Make sure you had fun coding 馃檭