Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MNIST 404 with torchvision>=0.9.1 #674

Merged
merged 2 commits into from Jun 25, 2021
Merged

Fix MNIST 404 with torchvision>=0.9.1 #674

merged 2 commits into from Jun 25, 2021

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Jun 24, 2021

What does this PR do?

Fixes #673.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #674 (501746d) into master (9990749) will increase coverage by 46.68%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #674       +/-   ##
===========================================
+ Coverage   25.56%   72.24%   +46.68%     
===========================================
  Files         118      118               
  Lines        7111     7145       +34     
===========================================
+ Hits         1818     5162     +3344     
+ Misses       5293     1983     -3310     
Flag Coverage 螖
cpu 72.24% <100.00%> (+46.68%) 猬嗭笍
pytest 72.24% <100.00%> (+46.68%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
pl_bolts/utils/__init__.py 92.59% <100.00%> (酶)
pl_bolts/losses/self_supervised_learning.py 71.33% <0.00%> (+0.18%) 猬嗭笍
pl_bolts/models/self_supervised/cpc/cpc_module.py 20.58% <0.00%> (+0.58%) 猬嗭笍
pl_bolts/models/vision/image_gpt/igpt_module.py 20.65% <0.00%> (+0.87%) 猬嗭笍
pl_bolts/datasets/imagenet_dataset.py 20.00% <0.00%> (+1.50%) 猬嗭笍
pl_bolts/datasets/kitti_dataset.py 34.61% <0.00%> (+1.92%) 猬嗭笍
pl_bolts/callbacks/vision/confused_logit.py 26.02% <0.00%> (+4.10%) 猬嗭笍
pl_bolts/callbacks/printing.py 71.18% <0.00%> (+6.77%) 猬嗭笍
pl_bolts/models/rl/common/cli.py 11.76% <0.00%> (+11.76%) 猬嗭笍
pl_bolts/models/self_supervised/amdim/datasets.py 56.89% <0.00%> (+12.06%) 猬嗭笍
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9990749...501746d. Read the comment docs.

@akihironitta akihironitta added fix fixing issues... datamodule Anything related to datamodules Priority High priority task labels Jun 24, 2021
@akihironitta akihironitta marked this pull request as ready for review June 24, 2021 22:42
@Borda Borda merged commit 3053740 into master Jun 25, 2021
@Borda Borda deleted the bugfix/mnist_404_error branch June 25, 2021 06:28
@sugatoray sugatoray mentioned this pull request Jul 4, 2021
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datamodule Anything related to datamodules fix fixing issues... Priority High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pl.bolts breaks torchvision.datasets.MNIST download
3 participants