Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

fix from_data_frame factory method with prediction df #1088

Conversation

daMichaelB
Copy link
Contributor

What does this PR do?

closes #1086

Creating an ImageClassificationData object with the from_data_frame factory method, was only working as long as i do not set

  • predict_images_root
  • predict_data_frame

Fixes #1086

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)

see #1086

  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
    image

all tests in test_data.py are working

  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

always 👍 😄

@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #1088 (0f7df42) into master (4d00c34) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 0f7df42 differs from pull request most recent head b64b621. Consider uploading reports for the commit b64b621 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1088      +/-   ##
==========================================
+ Coverage   87.75%   87.80%   +0.05%     
==========================================
  Files         281      281              
  Lines       12793    12793              
==========================================
+ Hits        11226    11233       +7     
+ Misses       1567     1560       -7     
Flag Coverage Δ
unittests 87.80% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/classification/data.py 97.50% <100.00%> (+5.00%) ⬆️
flash/image/classification/input.py 98.71% <0.00%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d00c34...b64b621. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM 😃

@ethanwharris ethanwharris merged commit 1a599ef into Lightning-Universe:master Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImageClassificationData.from_data_frame is not working when predict_data_frame is provided
2 participants