Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add TabularForecaster task based on PyTorch Forecasting #647

Merged

Conversation

sumanmichael
Copy link
Contributor

@sumanmichael sumanmichael commented Aug 10, 2021

What does this PR do?

Integrating https://github.com/jdb78/pytorch-forecasting into tabular/forecasting

Fixes #528 #529 #530 #531 #532

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
    Documentation to come in a follow-up
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@sumanmichael sumanmichael changed the title Feature/pytorch forecasting Adding tabular/forecasting Aug 10, 2021
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #647 (d005bb1) into master (ddd4c94) will decrease coverage by 3.76%.
The diff coverage is 89.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #647      +/-   ##
==========================================
- Coverage   89.01%   85.25%   -3.77%     
==========================================
  Files         230      237       +7     
  Lines       12720    12884     +164     
==========================================
- Hits        11323    10984     -339     
- Misses       1397     1900     +503     
Flag Coverage Δ
unittests 85.25% <89.26%> (-3.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ore/integrations/pytorch_forecasting/transforms.py 33.33% <33.33%> (ø)
flash/tabular/forecasting/model.py 85.00% <85.00%> (ø)
...h/core/integrations/pytorch_forecasting/adapter.py 91.66% <91.66%> (ø)
flash/tabular/forecasting/data.py 95.00% <95.00%> (ø)
flash/core/data/data_pipeline.py 95.11% <100.00%> (-0.13%) ⬇️
.../core/integrations/pytorch_forecasting/__init__.py 100.00% <100.00%> (ø)
...core/integrations/pytorch_forecasting/backbones.py 100.00% <100.00%> (ø)
flash/core/utilities/imports.py 90.97% <100.00%> (+0.06%) ⬆️
flash/core/utilities/providers.py 100.00% <100.00%> (ø)
flash/tabular/__init__.py 100.00% <100.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddd4c94...d005bb1. Read the comment docs.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sumanmichael sumanmichael marked this pull request as ready for review August 10, 2021 10:56
@sumanmichael sumanmichael marked this pull request as draft August 10, 2021 11:00
@Borda Borda added the task flash Task label Oct 28, 2021
@ethanwharris ethanwharris changed the title Adding tabular/forecasting Add TabularForecaster task based on PyTorch Forecasting Oct 28, 2021
@ethanwharris ethanwharris marked this pull request as ready for review October 29, 2021 12:57
@Lightning-Universe Lightning-Universe deleted a comment from pep8speaks Oct 29, 2021
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is huge, from top level screening it looks good :]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create TabularForecastingPreprocess stub
4 participants