Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description on how to run tests & build docs #2500

Merged
merged 20 commits into from
Apr 24, 2024
Merged

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Apr 13, 2024

What does this PR do?

Just because I sometimes forget how to run the ddp/non-ddp tests...

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭


馃摎 Documentation preview 馃摎: https://torchmetrics--2500.org.readthedocs.build/en/2500/

@SkafteNicki SkafteNicki added the documentation Improvements or additions to documentation label Apr 13, 2024
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Apr 13, 2024
tests/README.md Outdated Show resolved Hide resolved
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be also just make test

@Borda Borda enabled auto-merge (squash) April 14, 2024 14:33
@SkafteNicki SkafteNicki added the documentation Improvements or additions to documentation label Apr 16, 2024
@SkafteNicki SkafteNicki added this to the v1.4.0 milestone Apr 16, 2024
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Apr 16, 2024
@Borda
Copy link
Member

Borda commented Apr 17, 2024

it seems fine, but somehow, all CPU tests are failing at the stage of collecting tests...

@Borda Borda requested a review from a team April 23, 2024 13:57
@SkafteNicki
Copy link
Member Author

Not sure why the collection is failing, seems independent of the changes in the PR

@Borda
Copy link
Member

Borda commented Apr 23, 2024

Not sure why the collection is failing, seems independent of the changes in the PR

I may not agree as master and other PR proceed and here constantly failed...

@Borda Borda changed the title Description on how to run tests Description on how to run tests & build docs Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Merging #2500 (1311bbd) into master (3d52192) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2500   +/-   ##
======================================
  Coverage      69%     69%           
======================================
  Files         313     313           
  Lines       17598   17598           
======================================
  Hits        12147   12147           
  Misses       5451    5451           

Makefile Outdated Show resolved Hide resolved
@Borda Borda disabled auto-merge April 24, 2024 09:14
@Borda Borda merged commit 01f2c4b into master Apr 24, 2024
30 of 37 checks passed
@Borda Borda deleted the docs/test_instructions branch April 24, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants