Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward compatibility for breaking changes of imports from PL #965

Merged
merged 4 commits into from
May 18, 2023

Conversation

vishnu-dev
Copy link
Contributor

@vishnu-dev vishnu-dev commented Jan 22, 2023

What does this PR do?

Fixes #962

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Oh yes.

@vishnu-dev vishnu-dev marked this pull request as draft January 23, 2023 13:04
@Borda Borda marked this pull request as ready for review May 18, 2023 16:16
@Borda Borda enabled auto-merge (squash) May 18, 2023 16:16
@Borda Borda disabled auto-merge May 18, 2023 17:21
@Borda Borda merged commit 424b93b into Lightning-Universe:master May 18, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot import name 'LightningLoggerBase' from 'pytorch_lightning.loggers'
2 participants