Skip to content

Commit

Permalink
Unblock CI from failing CLI test (#19656)
Browse files Browse the repository at this point in the history
  • Loading branch information
awaelchli committed Mar 15, 2024
1 parent 5232cfd commit 51692c9
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions tests/tests_pytorch/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
from lightning.pytorch.utilities.exceptions import MisconfigurationException
from lightning.pytorch.utilities.imports import _TORCHVISION_AVAILABLE
from lightning_utilities import compare_version
from lightning_utilities.core.imports import RequirementCache
from lightning_utilities.test.warning import no_warning_call
from tensorboard.backend.event_processing import event_accumulator
from tensorboard.plugins.hparams.plugin_data_pb2 import HParamsPluginData
Expand Down Expand Up @@ -1481,6 +1482,12 @@ def __init__(self, activation: torch.nn.Module = lazy_instance(torch.nn.LeakyReL
assert cli.model.activation is not model.activation


@pytest.mark.xfail(
# https://github.com/omni-us/jsonargparse/issues/473
condition=(RequirementCache("jsonargparse>=4.27.6")),
strict=False,
reason="Breaking change for `lazy_instance` in jsonargparse",
)
def test_ddpstrategy_instantiation_and_find_unused_parameters(mps_count_0):
strategy_default = lazy_instance(DDPStrategy, find_unused_parameters=True)
with mock.patch("sys.argv", ["any.py", "--trainer.strategy.process_group_backend=group"]):
Expand Down

0 comments on commit 51692c9

Please sign in to comment.