-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataModule] PyTorch datasets as DataModules out of the box #2749
Comments
Hi! thanks for your contribution!, great first issue! |
I think it is a good suggestion, @PyTorchLightning/core-contributors |
yes. this is i think what we have already started in bolts! want to add the missing torchvision datasets to it? |
I'd like to, but I'm unsure if I have the time to do it in case this is very important. I could probably slowly do it over 2-3 weeks, if that's not an issue :) |
no problem. Maybe create GH issues for each dataset? and do one at a time? |
(gh issues in bolts) |
Makes sense. I'll open a separate issue per dataset in Bolts. Also, what do you thinkk about leaving this issue open until everything is implemented? |
Not sure what the value is in having duplicate tickets, but we can leave this open for now until new issues are opened in Bolts. Make sense? |
@InCogNiTo124 lets move the discussion to bolts repo for now. We're building out all sorts of support for different datasets there. The datasets you mentioned aren't from Thanks for the feedback on the new |
🚀 Feature
PyTorch already has datasets (MNIST, CIFAR, etc). It would be very convenient to provide those datasets out of the box as DataModules
Motivation
To reduce the boilerplate. I mean, if I had the possibility not to reimplement / copy-paste the same code again, I would rather not do that, and I'd use the already implemented solutions. The entire PyTorchLightning was built with this in mind, so this is only natural.
Pitch
To have the ability to write something along the lines of
Alternatives
Alternatively, it could be implemented as a PyTorchLightning Bolt, instead of here.
Additional context
None
The text was updated successfully, but these errors were encountered: