Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sigterm signal handling #10189

Merged
merged 7 commits into from Oct 29, 2021
Merged

Fix sigterm signal handling #10189

merged 7 commits into from Oct 29, 2021

Conversation

awaelchli
Copy link
Member

@awaelchli awaelchli commented Oct 27, 2021

What does this PR do?

Fixes #10154 and #9566

Before #9566, the special signal handler was only added for SLURM. Now, sigterm will be ignored by Lightning. only sigint can currently terminate a training process.

To reproduce, run bug_report_model.py and send sigterm (kill -15 process-name).

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 馃檭

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

@awaelchli awaelchli added bug Something isn't working priority: 0 High priority task labels Oct 27, 2021
@awaelchli awaelchli added this to the v1.5 milestone Oct 27, 2021
@awaelchli awaelchli marked this pull request as ready for review October 27, 2021 14:57
@awaelchli awaelchli changed the title Fix info message for sigterm signal handler Fix sigterm signal handling Oct 27, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tchaton
Copy link
Contributor

tchaton commented Oct 27, 2021

Wow ! Awesome catch !

@mergify mergify bot added the ready PRs ready to be merged label Oct 27, 2021
@mergify mergify bot removed the has conflicts label Oct 28, 2021
@awaelchli awaelchli enabled auto-merge (squash) October 28, 2021 23:54
@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #10189 (24a6028) into master (255e3ed) will increase coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #10189    +/-   ##
========================================
+ Coverage      89%      92%    +4%     
========================================
  Files         180      180            
  Lines       16193    16193            
========================================
+ Hits        14339    14954   +615     
+ Misses       1854     1239   -615     

@awaelchli awaelchli merged commit 6ed7a0c into master Oct 29, 2021
@awaelchli awaelchli deleted the bugfix/sigterm-message branch October 29, 2021 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lightning throws "bypassing sigterm" on DDP for unknown reason
4 participants