Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Loop.replace #10324

Merged
merged 12 commits into from Dec 16, 2021
Merged

Add Loop.replace #10324

merged 12 commits into from Dec 16, 2021

Conversation

carmocca
Copy link
Member

@carmocca carmocca commented Nov 2, 2021

What does this PR do?

Fixes #10309

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @justusschock @ananthsub @ninginthecloud

@carmocca carmocca added the feature Is an improvement or enhancement label Nov 2, 2021
@carmocca carmocca added this to the v1.6 milestone Nov 2, 2021
@carmocca carmocca self-assigned this Nov 2, 2021
@carmocca carmocca marked this pull request as draft November 3, 2021 00:20
@carmocca carmocca mentioned this pull request Nov 24, 2021
9 tasks
@carmocca carmocca changed the base branch from master to refactor/avoid-loop-optional-types November 24, 2021 18:20
@carmocca carmocca added the loops Related to the Loop API label Nov 24, 2021
Base automatically changed from refactor/avoid-loop-optional-types to master November 26, 2021 18:00
@carmocca carmocca marked this pull request as ready for review November 26, 2021 18:06
pytorch_lightning/loops/base.py Outdated Show resolved Hide resolved
pytorch_lightning/loops/base.py Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Dec 1, 2021
@mergify mergify bot removed the has conflicts label Dec 15, 2021
pytorch_lightning/loops/base.py Outdated Show resolved Hide resolved
pytorch_lightning/loops/base.py Outdated Show resolved Hide resolved
@mergify mergify bot added ready PRs ready to be merged has conflicts labels Dec 15, 2021
@mergify mergify bot removed the has conflicts label Dec 15, 2021
@carmocca carmocca enabled auto-merge (squash) December 16, 2021 17:12
@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #10324 (a3018ac) into master (ffb1a75) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #10324    +/-   ##
========================================
- Coverage      92%      88%    -4%     
========================================
  Files         177      177            
  Lines       16492    16510    +18     
========================================
- Hits        15161    14564   -597     
- Misses       1331     1946   +615     

@carmocca carmocca merged commit 46d6fbf into master Dec 16, 2021
@carmocca carmocca deleted the feat/loop-replace branch December 16, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement loops Related to the Loop API ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Loop.replace to improve the customization UX
5 participants