Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2/n Move Precision Plugin into strategy - move optimizer related logics #10596

Merged
merged 23 commits into from Nov 30, 2021

Conversation

four4fish
Copy link
Contributor

@four4fish four4fish commented Nov 18, 2021

What does this PR do?

1/n Move Precision Plugin into Strategy and update references
2/n Move optimizer, lr to Strategy
3/n Simplify and reduce hooks and redundancies

Fixes #7324 which is part of #10416

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@four4fish four4fish marked this pull request as draft November 18, 2021 04:24
@four4fish four4fish changed the title [Not ready for review] 2/n Move Precision Plugin into strategy - move optimizer related logics 2/n Move Precision Plugin into strategy - move optimizer related logics Nov 19, 2021
pytorch_lightning/accelerators/accelerator.py Outdated Show resolved Hide resolved
pytorch_lightning/accelerators/accelerator.py Show resolved Hide resolved
pytorch_lightning/accelerators/gpu.py Outdated Show resolved Hide resolved
pytorch_lightning/lite/wrappers.py Outdated Show resolved Hide resolved
pytorch_lightning/plugins/precision/apex_amp.py Outdated Show resolved Hide resolved
pytorch_lightning/plugins/precision/apex_amp.py Outdated Show resolved Hide resolved
pytorch_lightning/plugins/training_type/deepspeed.py Outdated Show resolved Hide resolved
pytorch_lightning/plugins/training_type/ipu.py Outdated Show resolved Hide resolved
tests/lite/test_wrappers.py Outdated Show resolved Hide resolved
@four4fish four4fish marked this pull request as ready for review November 20, 2021 01:18
@four4fish four4fish linked an issue Nov 20, 2021 that may be closed by this pull request
4 tasks
pytorch_lightning/accelerators/accelerator.py Outdated Show resolved Hide resolved
pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
Copy link
Member

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from existing open comments, LGTM, nice work!

pytorch_lightning/plugins/training_type/tpu_spawn.py Outdated Show resolved Hide resolved
pytorch_lightning/lite/wrappers.py Show resolved Hide resolved
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Nov 24, 2021
@four4fish four4fish added this to the 1.6 milestone Nov 24, 2021
@mergify mergify bot removed the has conflicts label Nov 27, 2021
@mergify mergify bot removed the has conflicts label Nov 29, 2021
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #10596 (cafbbd4) into master (8bf7f9c) will decrease coverage by 2%.
The diff coverage is 76%.

@@           Coverage Diff            @@
##           master   #10596    +/-   ##
========================================
- Coverage      90%      88%    -2%     
========================================
  Files         177      177            
  Lines       16505    16509     +4     
========================================
- Hits        14920    14535   -385     
- Misses       1585     1974   +389     

@awaelchli awaelchli merged commit 1d28785 into Lightning-AI:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Main Issue] Accelerator and Plugin refactor Precision Plugins should be part of Training Type Plugins
6 participants