Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate BaseProfiler in favor of Profiler #12150

Merged
merged 25 commits into from Mar 21, 2022
Merged

Deprecate BaseProfiler in favor of Profiler #12150

merged 25 commits into from Mar 21, 2022

Conversation

akashkw
Copy link
Contributor

@akashkw akashkw commented Feb 28, 2022 •
edited

What does this PR do?

Fixes #11409

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

ananthsub
ananthsub reviewed Mar 1, 2022
View reviewed changes
pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
@akashkw akashkw marked this pull request as ready for review March 7, 2022 19:40
ananthsub
ananthsub approved these changes Mar 7, 2022
View reviewed changes
pytorch_lightning/profiler/base.py Outdated Show resolved Hide resolved
@ananthsub ananthsub added this to the 1.6 milestone Mar 8, 2022
@mergify mergify bot added the has conflicts label Mar 8, 2022
krshrimali
krshrimali approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ⚡

carmocca
carmocca approved these changes Mar 21, 2022
View reviewed changes
docs/source/api_references.rst Outdated Show resolved Hide resolved
pytorch_lightning/profiler/base.py Outdated Show resolved Hide resolved
kaushikb11
kaushikb11 suggested changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add profiler file with the Profiler class

@daniellepintz
Copy link
Contributor

daniellepintz commented Mar 21, 2022 •
edited

@kaushikb11 Will do! Mind removing your block on this PR so I can make that change and then we can merge this? I think it's important that we get this in for 1.6 since we also deprecated AbstractProfiler in 1.6

@kaushikb11
Copy link
Contributor

Mind removing your block on this PR so I can make that change and then we can merge this?

Sure, also to note the release date has changed to 29th.

@kaushikb11 kaushikb11 self-requested a review March 21, 2022 18:21
@daniellepintz
Copy link
Contributor

Oh, I didn't know! Then no stress. Thanks!

@mergify mergify bot removed the has conflicts label Mar 21, 2022
@mergify mergify bot added the ready PRs ready to be merged label Mar 21, 2022
@kaushikb11 kaushikb11 enabled auto-merge (squash) March 21, 2022 19:06
kaushikb11 and others added 4 commits March 22, 2022 00:54
@kaushikb11
Fix typing
c8faa65
@kaushikb11 @daniellepintz
Update tests/deprecated_api/test_remove_1-8.py
d618084 
Co-authored-by: Danielle Pintz <38207072+daniellepintz@users.noreply.github.com>
@kaushikb11 @daniellepintz
Update tests/deprecated_api/test_remove_1-8.py
61d4638 
Co-authored-by: Danielle Pintz <38207072+daniellepintz@users.noreply.github.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
ab470f9 
for more information, see https://pre-commit.ci
@kaushikb11 kaushikb11 merged commit bc1c8b9 into Lightning-AI:master Mar 21, 2022
@Borda Borda mentioned this pull request Mar 9, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniellepintz daniellepintz daniellepintz approved these changes

@ananthsub ananthsub ananthsub approved these changes

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@carmocca carmocca carmocca approved these changes

@krshrimali krshrimali krshrimali approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@edenlightning edenlightning Awaiting requested review from edenlightning

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@justusschock justusschock Awaiting requested review from justusschock

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

Assignees
No one assigned
Labels
deprecation Includes a deprecation profiler ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

[RFC] Move file-based code in Profiler to utilities
8 participants
@akashkw @daniellepintz @kaushikb11 @ananthsub @awaelchli @Borda @carmocca @krshrimali