Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add callout items to the Docs landing page #12196

Merged
merged 5 commits into from Mar 7, 2022
Merged

Add callout items to the Docs landing page #12196

merged 5 commits into from Mar 7, 2022

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Mar 3, 2022 •
edited

What does this PR do?

Addresses #10632

Screen Shot 2022-03-03 at 7 14 47 PM

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @rohitgr7

@kaushikb11 kaushikb11 added the docs Documentation related label Mar 3, 2022
@kaushikb11 kaushikb11 added this to the 1.6 milestone Mar 3, 2022
@kaushikb11 kaushikb11 self-assigned this Mar 3, 2022
rohitgr7
rohitgr7 approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!

docs/source/index.rst Outdated Show resolved Hide resolved
docs/source/index.rst Show resolved Hide resolved
krshrimali
krshrimali approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggestion/nit, otherwise LGTM.

docs/source/index.rst Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Mar 3, 2022
ethanwharris
ethanwharris approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

awaelchli
awaelchli approved these changes Mar 4, 2022
View reviewed changes
docs/source/index.rst Outdated Show resolved Hide resolved
@kaushikb11 kaushikb11 merged commit 9b01160 into master Mar 7, 2022
@kaushikb11 kaushikb11 deleted the update/landing_page branch March 7, 2022 08:46
czxttkl pushed a commit to czxttkl/ReAgent that referenced this pull request Mar 7, 2022
@tangbinh @facebook-github-bot
Add callout items to the Docs landing page (#12196)
effbee0 
Summary:
### New commit log messages
- [9b011606f Add callout items to the Docs landing page (#12196)](Lightning-AI/pytorch-lightning#12196)

Differential Revision: D34687261

fbshipit-source-id: 4bb336258433b36f43971185c010260c68734d09
@czxttkl czxttkl mentioned this pull request Mar 7, 2022
Closed
This was referenced Mar 9, 2022
Closed
Closed
facebook-github-bot pushed a commit to facebookresearch/recipes that referenced this pull request Mar 9, 2022
@tangbinh @facebook-github-bot
Add callout items to the Docs landing page (#12196)
5ec13d4 
Summary:
X-link: facebookresearch/d2go#189

Pull Request resolved: #14

X-link: facebookresearch/ReAgent#616

### New commit log messages
- [9b011606f Add callout items to the Docs landing page (#12196)](Lightning-AI/pytorch-lightning#12196)

Reviewed By: edward-io

Differential Revision: D34687261

fbshipit-source-id: 3ef6be5169a855582384f9097a962d2261625882
facebook-github-bot pushed a commit to facebookresearch/d2go that referenced this pull request Mar 9, 2022
@tangbinh @facebook-github-bot
Add callout items to the Docs landing page (#12196)
56a2eda 
Summary:
Pull Request resolved: #189

X-link: facebookresearch/recipes#14

X-link: facebookresearch/ReAgent#616

### New commit log messages
- [9b011606f Add callout items to the Docs landing page (#12196)](Lightning-AI/pytorch-lightning#12196)

Reviewed By: edward-io

Differential Revision: D34687261

fbshipit-source-id: 3ef6be5169a855582384f9097a962d2261625882
facebook-github-bot pushed a commit to facebookresearch/mmf that referenced this pull request Mar 9, 2022
@tangbinh @facebook-github-bot
[PyTorchLightning/pytorch-lightning] Add callout items to the Docs la…
010d8d7 
…nding page (#12196) (#189)

Summary:
X-link: facebookresearch/d2go#189

X-link: facebookresearch/recipes#14

X-link: facebookresearch/ReAgent#616

### New commit log messages
- [9b011606f Add callout items to the Docs landing page (#12196)](Lightning-AI/pytorch-lightning#12196)

Reviewed By: edward-io

Differential Revision: D34687261

fbshipit-source-id: 3ef6be5169a855582384f9097a962d2261625882
facebook-github-bot pushed a commit to facebookresearch/ReAgent that referenced this pull request Mar 9, 2022
@tangbinh @facebook-github-bot
Add callout items to the Docs landing page (#12196) (#189)
a21a1a9 
Summary:
X-link: facebookresearch/d2go#189

X-link: facebookresearch/recipes#14

Pull Request resolved: #616

### New commit log messages
- [9b011606f Add callout items to the Docs landing page (#12196)](Lightning-AI/pytorch-lightning#12196)

Reviewed By: edward-io

Differential Revision: D34687261

fbshipit-source-id: 3ef6be5169a855582384f9097a962d2261625882
Borda pushed a commit to jerome-habana/lightning that referenced this pull request Mar 10, 2022
@kaushikb11 @awaelchli
@carmocca @Borda
Add callout items to the Docs landing page (Lightning-AI#12196)
28bc4f0 
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@ethanwharris ethanwharris ethanwharris approved these changes

@krshrimali krshrimali krshrimali approved these changes

@akihironitta akihironitta akihironitta approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@edenlightning edenlightning Awaiting requested review from edenlightning

@tchaton tchaton Awaiting requested review from tchaton

@Borda Borda Awaiting requested review from Borda Borda is a code owner

Assignees

@kaushikb11 kaushikb11

Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kaushikb11 @awaelchli @ethanwharris @krshrimali @akihironitta @rohitgr7 @carmocca