Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added args parameter to LightningCLI to ease running from within Python #14596

Merged
merged 14 commits into from Sep 19, 2022
Merged

Added args parameter to LightningCLI to ease running from within Python #14596

merged 14 commits into from Sep 19, 2022

Conversation

mauvilsa
Copy link
Contributor

@mauvilsa mauvilsa commented Sep 8, 2022 •
edited

What does this PR do?

As the title says and more details in the updated docs. This was recently discussed in the lightning-cli slack channel and has come up a few times in comments and discussions.

Fixes #13277

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 8, 2022
@mauvilsa mauvilsa changed the title Added args parameter to LightningCLI to ease running from within Python. Added args parameter to LightningCLI to ease running from within Python Sep 8, 2022
@mauvilsa mauvilsa marked this pull request as ready for review September 8, 2022 06:27
@carmocca carmocca added lightningcli pl.cli.LightningCLI feature Is an improvement or enhancement and removed lightningcli pl.cli.LightningCLI labels Sep 8, 2022
@Borda Borda enabled auto-merge (squash) September 9, 2022 19:07
@mergify mergify bot added the ready PRs ready to be merged label Sep 9, 2022
@Borda Borda added this to the pl:1.8 milestone Sep 12, 2022
@mergify mergify bot removed the ready PRs ready to be merged label Sep 12, 2022
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed has conflicts ready PRs ready to be merged labels Sep 12, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 15, 2022
@Borda
Copy link
Member

Borda commented Sep 15, 2022

@mauvilsa mind checking the pending conversation and marking them as resolved if they were addressed?
cc: @carmocca

auto-merge was automatically disabled September 19, 2022 05:08

Head branch was pushed to by a user without write access

carmocca
carmocca approved these changes Sep 19, 2022
View reviewed changes
docs/source-pytorch/cli/lightning_cli_intermediate.rst Show resolved Hide resolved
docs/source-pytorch/cli/lightning_cli_advanced_3.rst Outdated Show resolved Hide resolved
src/pytorch_lightning/cli.py Outdated Show resolved Hide resolved
tests/tests_pytorch/test_cli.py Outdated Show resolved Hide resolved
mauvilsa and others added 2 commits September 19, 2022 17:33
@mauvilsa @carmocca
Apply suggestions from code review
02ea769 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@mauvilsa
Address comments in pull request.
9843c58
@carmocca carmocca enabled auto-merge (squash) September 19, 2022 16:53
@carmocca carmocca merged commit 3064c28 into Lightning-AI:master Sep 19, 2022
@mauvilsa mauvilsa deleted the cli-args-param branch September 19, 2022 17:41
rohitgr7 pushed a commit that referenced this pull request Sep 24, 2022
@mauvilsa @carmocca
@Borda @rohitgr7
Added args parameter to LightningCLI to ease running from within Pyth…
207eb11 
…on (#14596)

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
@carmocca carmocca mentioned this pull request Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wunderox wunderox wunderox left review comments

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@carmocca carmocca carmocca approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@otaj otaj Awaiting requested review from otaj

@edenlightning edenlightning Awaiting requested review from edenlightning

@tchaton tchaton Awaiting requested review from tchaton

@Felonious-Spellfire Felonious-Spellfire Awaiting requested review from Felonious-Spellfire

@williamFalcon williamFalcon Awaiting requested review from williamFalcon williamFalcon is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees
No one assigned
Labels
feature Is an improvement or enhancement lightningcli pl.cli.LightningCLI pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mauvilsa @Borda @awaelchli @carmocca @wunderox