Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning #1634

Merged
merged 2 commits into from Apr 27, 2020
Merged

Remove warning #1634

merged 2 commits into from Apr 27, 2020

Conversation

justusschock
Copy link
Member

@justusschock justusschock commented Apr 27, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

as discussed in #1631.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@justusschock justusschock requested review from Borda and a team April 27, 2020 09:42
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was quite a useless warning as it was raised with a normal run and this change was written in the changelog

@Borda Borda added docs Documentation related ready PRs ready to be merged labels Apr 27, 2020
@mergify mergify bot requested a review from a team April 27, 2020 10:09
@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #1634 into master will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1634   +/-   ##
======================================
- Coverage      89%     89%   -0%     
======================================
  Files          71      71           
  Lines        4164    4163    -1     
======================================
- Hits         3689    3688    -1     
  Misses        475     475           

@awaelchli
Copy link
Member

I actually didn't think of this when I made the progress bar callback. Was the intention that we make this change manually when we get to 0.8?

@williamFalcon williamFalcon merged commit 89877fe into master Apr 27, 2020
@Borda Borda deleted the remove_warning branch April 27, 2020 11:54
@Borda Borda added this to the 0.7.5 milestone Apr 27, 2020
@Borda Borda restored the remove_warning branch April 27, 2020 13:28
Borda added a commit that referenced this pull request Apr 27, 2020
Remove warning

Update CHANGELOG.md
@Borda Borda deleted the remove_warning branch April 27, 2020 15:25
@Borda Borda modified the milestones: 0.7.6, 0.7.5 Apr 27, 2020
@Borda Borda modified the milestones: 0.7.5, v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants