Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix auto scale batch size not working with precision=16 #3045

Merged
merged 6 commits into from Aug 19, 2020

Conversation

awaelchli
Copy link
Member

@awaelchli awaelchli commented Aug 19, 2020

What does this PR do?

Fixes #3025
Fixes #2655 (we may need an extra test)

Made sure test is failing on master

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@awaelchli awaelchli added the bug Something isn't working label Aug 19, 2020
@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #3045 into master will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #3045    +/-   ##
=======================================
- Coverage      90%     86%    -4%     
=======================================
  Files          81      81            
  Lines        7673    7673            
=======================================
- Hits         6913    6605   -308     
- Misses        760    1068   +308     

@awaelchli awaelchli marked this pull request as ready for review August 19, 2020 02:39
@mergify mergify bot requested a review from a team August 19, 2020 02:40
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot requested a review from a team August 19, 2020 07:06
@mergify mergify bot requested a review from a team August 19, 2020 07:26
@mergify mergify bot requested a review from a team August 19, 2020 16:36
@mergify mergify bot merged commit 89a5d8f into master Aug 19, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 19, 2020

Great job! =)

@ananyahjha93 ananyahjha93 deleted the bugfix/batch-size-scaler-amp branch August 19, 2020 20:44
@Borda Borda added this to the 0.9.0 milestone Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
5 participants