ref: separate argparse #3428
Merged
ref: separate argparse #3428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3428 +/- ##
=======================================
+ Coverage 85% 88% +3%
=======================================
Files 100 100
Lines 8034 8250 +216
=======================================
+ Hits 6862 7287 +425
+ Misses 1172 963 -209 |
7 tasks
maclandrol
reviewed
Oct 9, 2020
|
|
||
| if arg == 'gpus' or arg == 'tpu_cores': | ||
| use_type = _gpus_allowed_type | ||
| arg_default = _gpus_arg_default |
There was a problem hiding this comment.
@williamFalcon Should this be a function ? Raising issue in hparams serialization with omegaconf, when --gpus is not explicitly provided in the command line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.