Write predictions in LightningModule instead of EvalResult #3882
+28
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananthsub
reviewed
Oct 5, 2020
Comment on lines
+307
to
+313
| def write_prediction(self, name, value, filename='predictions.pt'): | ||
| self.trainer.evaluation_loop.predictions._add_prediction(name, value, filename) | ||
|
|
||
| def write_prediction_dict(self, predictions_dict, filename='predictions.pt'): | ||
| for k, v in predictions_dict.items(): | ||
| self.write_prediction(k, v, filename) | ||
|
|
There was a problem hiding this comment.
does this write out as a CSV file? do you think this makes more sense as a callback?
There was a problem hiding this comment.
writes to list of dictionaries via torch.save. making predictions is different for every use case, so this way lets user define how they want to do it.
Could be achieved with callback (in fact, that's how I originally was doing this), but that would only work for 1 use case.
Codecov Report
@@ Coverage Diff @@
## master #3882 +/- ##
=======================================
+ Coverage 84% 87% +4%
=======================================
Files 119 117 -2
Lines 9764 9155 -609
=======================================
- Hits 8169 8002 -167
+ Misses 1595 1153 -442 |
|
@nateraw please use fsspec here: https://github.com/PyTorchLightning/pytorch-lightning/blob/cea5f1f53876399dfaa0d37accdc527af7ca39af/pytorch_lightning/trainer/supporters.py#L138-L165 so we can save files beyond local disk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3870
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃