Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop deprecated fbeta metrics #5322

Merged
merged 4 commits into from Jan 2, 2021
Merged

drop deprecated fbeta metrics #5322

merged 4 commits into from Jan 2, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 1, 2021

What does this PR do?

these metrics were moved and changed cases

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes [if needed]?
  • Did you write any new necessary tests [no need for typos, docs]?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone are aligned!

Did you have fun?

Make sure you had fun coding 馃檭

@pep8speaks
Copy link

pep8speaks commented Jan 1, 2021

Hello @Borda! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 馃嵒

Comment last updated at 2021-01-02 00:49:26 UTC

@Borda Borda enabled auto-merge (squash) January 1, 2021 19:27
@codecov
Copy link

codecov bot commented Jan 1, 2021

Codecov Report

Merging #5322 (badc955) into release/1.2-dev (fb90eec) will decrease coverage by 0%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           release/1.2-dev   #5322   +/-   ##
===============================================
- Coverage               93%     93%   -0%     
===============================================
  Files                  146     146           
  Lines                10202   10199    -3     
===============================================
- Hits                  9477    9474    -3     
  Misses                 725     725           

@Borda Borda added the ready PRs ready to be merged label Jan 1, 2021
@Borda Borda merged commit f2c2a69 into release/1.2-dev Jan 2, 2021
@Borda Borda deleted the deprecated/drop-fbeta branch January 2, 2021 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants