Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accelerator Refactor/RPC + Sharded #5732

Merged
merged 11 commits into from Feb 1, 2021
Merged

Accelerator Refactor/RPC + Sharded #5732

merged 11 commits into from Feb 1, 2021

Conversation

justusschock
Copy link
Member

This should be the last PR adding new classes for the accelerator refactor (#5616 ).

It should be merged after #5719 .

It adds support for sharded training and RPC/Model parallelism.

@justusschock justusschock added this to the 1.2 milestone Feb 1, 2021
@justusschock justusschock self-assigned this Feb 1, 2021
@justusschock justusschock added this to In progress in Refactor Accelerator Backends via automation Feb 1, 2021
@pep8speaks
Copy link

pep8speaks commented Feb 1, 2021

Hello @justusschock! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-02-01 11:19:59 UTC

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! I think we will have to be careful with duplicated code for Plugin as Shared.

pytorch_lightning/plugins/training_type/rpc.py Outdated Show resolved Hide resolved
pytorch_lightning/plugins/training_type/rpc.py Outdated Show resolved Hide resolved
pytorch_lightning/plugins/training_type/rpc_sequential.py Outdated Show resolved Hide resolved
pytorch_lightning/plugins/training_type/rpc_sequential.py Outdated Show resolved Hide resolved
pytorch_lightning/plugins/training_type/sharded_spawn.py Outdated Show resolved Hide resolved
@Borda
Copy link
Member

Borda commented Feb 1, 2021

just add chlog :]

@Borda Borda added the ready PRs ready to be merged label Feb 1, 2021
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #5732 (f1eb8b1) into release/1.2-dev (963c17b) will decrease coverage by 0%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##           release/1.2-dev   #5732    +/-   ##
================================================
- Coverage               89%     89%    -0%     
================================================
  Files                  173     173            
  Lines                12495   12339   -156     
================================================
- Hits                 11171   11007   -164     
- Misses                1324    1332     +8     

Refactor Accelerator Backends automation moved this from In progress to in Review Feb 1, 2021
@awaelchli awaelchli merged commit 9064b83 into release/1.2-dev Feb 1, 2021
Refactor Accelerator Backends automation moved this from in Review to Done Feb 1, 2021
@awaelchli awaelchli deleted the sharded_rpc branch February 1, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants