MlflowLogger limit parameter value length 250 char #5893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ducthienbui97
requested review from
awaelchli,
Borda and
tchaton
as code owners
Codecov Report
@@ Coverage Diff @@
## master #5893 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 159 159
Lines 11209 11097 -112
=======================================
- Hits 10440 9911 -529
- Misses 769 1186 +417 |
Borda
added
feature
Borda
requested review from
ananyahjha93,
carmocca,
edenlightning,
justusschock,
SeanNaren,
SkafteNicki,
teddykoker and
williamFalcon
as code owners
|
@Borda Thanks, updated |
awaelchli
reviewed
Feb 10, 2021
pytorch_lightning/loggers/mlflow.py
Outdated
| @@ -150,6 +150,10 @@ def log_hyperparams(self, params: Union[Dict[str, Any], Namespace]) -> None: | |||
| params = self._convert_params(params) | |||
| params = self._flatten_dict(params) | |||
| for k, v in params.items(): | |||
| if len(str(v)) > 250: | |||
| log.warning(f"Mlflow only allows parameters with up to 250 characters. Discard {k}={v}") | |||
There was a problem hiding this comment.
just to double check, it is actually v not k that has a limit here?
There was a problem hiding this comment.
also let's use rank_zero_warn here instead of log.warning?
There was a problem hiding this comment.
@awaelchli yeah, it's v, there are feature requests in mlflow about that
mlflow/mlflow#3931
mlflow/mlflow#1976
awaelchli
approved these changes
Feb 11, 2021
SkafteNicki
approved these changes
Feb 11, 2021
carmocca
approved these changes
Feb 12, 2021
Borda
approved these changes
Feb 15, 2021
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #5892 (issue) <- this links related issue to this PR
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 馃檭