Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

move accelerator_connector.py to the connectors subfolder #6033

Merged
merged 2 commits into from Feb 17, 2021

Conversation

awaelchli
Copy link
Member

@awaelchli awaelchli commented Feb 17, 2021

What does this PR do?

Follow up to #5743
Moves the accelerator connector to the folder where all other connectors are.
This has no implications for the user, as this class is internal.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #6033 (4813dc6) into master (5157ba5) will decrease coverage by 2%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #6033    +/-   ##
=======================================
- Coverage      93%     91%    -2%     
=======================================
  Files         160     160            
  Lines       11340   11342     +2     
=======================================
- Hits        10550   10282   -268     
- Misses        790    1060   +270     

@Borda Borda enabled auto-merge (squash) February 17, 2021 17:09
@Borda Borda added the ready PRs ready to be merged label Feb 17, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda merged commit e0bb33c into master Feb 17, 2021
@Borda Borda deleted the refactor/move-accelerator-connector branch February 17, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants