Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the number of training batches used in the training loop #653

Merged
merged 6 commits into from Jan 5, 2020
Merged

Fix the number of training batches used in the training loop #653

merged 6 commits into from Jan 5, 2020

Conversation

kuynzereb
Copy link
Contributor

This PR resolves #631

Now we process num_training_batches + 1 batches instead of num_training_batches batches in the training loop if num_training_batches < len(train_dataloader). This PR fixes it.

@kuynzereb kuynzereb mentioned this pull request Dec 27, 2019
Merged
@kuynzereb kuynzereb mentioned this pull request Dec 27, 2019
Merged
3 tasks
Borda
Borda approved these changes Dec 28, 2019
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamFalcon williamFalcon merged commit 12edc30 into Lightning-AI:master Jan 5, 2020
@kuynzereb kuynzereb deleted the fix_number_of_training_batches branch January 14, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

num_training_batches rounds down, causing 0 batches count
3 participants
@kuynzereb @Borda @williamFalcon