Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logger_connector legacy code #6733

Merged
merged 3 commits into from Mar 30, 2021
Merged

Remove logger_connector legacy code #6733

merged 3 commits into from Mar 30, 2021

Conversation

carmocca
Copy link
Member

@carmocca carmocca commented Mar 29, 2021

What does this PR do?

Removes legacy code.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added this to the 1.3 milestone Mar 29, 2021
@carmocca carmocca self-assigned this Mar 29, 2021
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #6733 (f03ec12) into master (f79a13e) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #6733    +/-   ##
=======================================
- Coverage      91%     87%    -4%     
=======================================
  Files         192     192            
  Lines       12231   12174    -57     
=======================================
- Hits        11184   10609   -575     
- Misses       1047    1565   +518     

@carmocca carmocca changed the title [WIP] Remove legacy code Remove logger_connector legacy code Mar 29, 2021
@carmocca carmocca marked this pull request as ready for review March 29, 2021 23:11
@carmocca carmocca added the ready PRs ready to be merged label Mar 29, 2021
@carmocca carmocca enabled auto-merge (squash) March 29, 2021 23:31
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally :D

@carmocca carmocca merged commit 9044470 into master Mar 30, 2021
@carmocca carmocca deleted the remove-legacy-code branch March 30, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants