Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Adagrad optimizer not working with DDP/GPU #7277

Merged
merged 28 commits into from May 2, 2021
Merged

Conversation

awaelchli
Copy link
Member

What does this PR do?

Fixes #6824

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

@awaelchli awaelchli added bug Something isn't working distributed Generic distributed-related topic labels Apr 29, 2021
@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #7277 (a3f7f84) into master (16d6c98) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #7277   +/-   ##
======================================
- Coverage      91%     91%   -0%     
======================================
  Files         200     200           
  Lines       12854   12941   +87     
======================================
+ Hits        11722   11776   +54     
- Misses       1132    1165   +33     

@awaelchli awaelchli marked this pull request as ready for review April 30, 2021 16:17
@awaelchli awaelchli changed the title Fix Adagrad optimizer not working with DDP/GPU [wip] Fix Adagrad optimizer not working with DDP/GPU Apr 30, 2021
@awaelchli awaelchli added this to the v1.3 milestone Apr 30, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

CHANGELOG.md Outdated Show resolved Hide resolved
@awaelchli awaelchli changed the title [wip] Fix Adagrad optimizer not working with DDP/GPU Fix Adagrad optimizer not working with DDP/GPU Apr 30, 2021
@pep8speaks
Copy link

pep8speaks commented Apr 30, 2021

Hello @awaelchli! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 馃嵒

Comment last updated at 2021-04-30 17:48:44 UTC

@mergify mergify bot removed the has conflicts label Apr 30, 2021
tests/trainer/optimization/test_optimizers.py Outdated Show resolved Hide resolved
awaelchli and others added 2 commits April 30, 2021 19:36
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working distributed Generic distributed-related topic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adagrad not working with GPU and DDP
5 participants