Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune deprecated classif. metrics #7499

Merged
merged 14 commits into from May 12, 2021
Merged

Prune deprecated classif. metrics #7499

merged 14 commits into from May 12, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented May 12, 2021

What does this PR do?

remove deprecated classification metrics, this was done even before cutting-out TM

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

@Borda Borda added the refactor label May 12, 2021
@Borda Borda added this to the v1.4 milestone May 12, 2021
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #7499 (023fae5) into master (140b0c7) will increase coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #7499    +/-   ##
=======================================
  Coverage      92%     92%            
=======================================
  Files         199     198     -1     
  Lines       13057   12927   -130     
=======================================
- Hits        11990   11904    -86     
+ Misses       1067    1023    -44     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda added the ready PRs ready to be merged label May 12, 2021
@Borda Borda enabled auto-merge (squash) May 12, 2021 14:48
@mergify mergify bot removed the has conflicts label May 12, 2021
@Borda Borda merged commit 9698109 into master May 12, 2021
@Borda Borda deleted the prune/metrics branch May 12, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants