Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LightningCLI(save_config_overwrite=False|True) #8059

Merged
merged 4 commits into from Jun 21, 2021
Merged

Conversation

carmocca
Copy link
Member

@carmocca carmocca commented Jun 21, 2021

What does this PR do?

Add overwrite to SaveConfigCallback + plumbing for it
Improve error message
Add test

cc: @mauvilsa

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added feature Is an improvement or enhancement argparse (removed) Related to argument parsing (argparse, Hydra, ...) labels Jun 21, 2021
@carmocca carmocca added this to the v1.4 milestone Jun 21, 2021
@carmocca carmocca self-assigned this Jun 21, 2021
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #8059 (4b6097f) into master (2303f9c) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8059   +/-   ##
======================================
- Coverage      92%     91%   -0%     
======================================
  Files         210     210           
  Lines       13579   13581    +2     
======================================
- Hits        12452   12416   -36     
- Misses       1127    1165   +38     

@carmocca carmocca changed the title LightningCLI exist_ok Add LightningCLI(save_config_exist_ok=False|True) Jun 21, 2021
pytorch_lightning/utilities/cli.py Outdated Show resolved Hide resolved
@carmocca carmocca changed the title Add LightningCLI(save_config_exist_ok=False|True) Add LightningCLI(save_config_overwrite=False|True) Jun 21, 2021
pytorch_lightning/utilities/cli.py Show resolved Hide resolved
@carmocca carmocca enabled auto-merge (squash) June 21, 2021 13:56
@carmocca carmocca added the ready PRs ready to be merged label Jun 21, 2021
@carmocca carmocca merged commit d9bf975 into master Jun 21, 2021
@carmocca carmocca deleted the feat/cli-exist-ok branch June 21, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argparse (removed) Related to argument parsing (argparse, Hydra, ...) feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants