Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear dataloader references before attaching new dataloaders to Trainer #8442

Merged
merged 5 commits into from Jul 19, 2021

Conversation

awaelchli
Copy link
Member

@awaelchli awaelchli commented Jul 16, 2021

What does this PR do?

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 馃檭

@awaelchli awaelchli added the bug Something isn't working label Jul 16, 2021
@awaelchli awaelchli added this to the v1.3.x milestone Jul 16, 2021
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #8442 (c055bf1) into master (374fae5) will increase coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #8442    +/-   ##
=======================================
+ Coverage      89%     92%    +4%     
=======================================
  Files         217     217            
  Lines       14223   14227     +4     
=======================================
+ Hits        12605   13132   +527     
+ Misses       1618    1095   -523     

@awaelchli awaelchli added the priority: 0 High priority task label Jul 16, 2021
@awaelchli awaelchli marked this pull request as ready for review July 16, 2021 10:08
@awaelchli awaelchli added the data handling Generic data-related topic label Jul 16, 2021
tests/trainer/test_dataloaders.py Show resolved Hide resolved
@carmocca carmocca added the ready PRs ready to be merged label Jul 16, 2021
@justusschock justusschock enabled auto-merge (squash) July 19, 2021 07:23
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data handling Generic data-related topic priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants