Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for model weights equality when fault-tolerant training #9481

Merged
merged 2 commits into from Sep 13, 2021

Conversation

awaelchli
Copy link
Member

@awaelchli awaelchli commented Sep 13, 2021

What does this PR do?

Extends a test by asserting equality of model weights when comparing a full training run with one that got interrupted and resumed.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added the ci Continuous Integration label Sep 13, 2021
@awaelchli awaelchli added this to the v1.5 milestone Sep 13, 2021
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #9481 (ca43bed) into master (0cb5508) will decrease coverage by 4%.
The diff coverage is n/a.

❗ Current head ca43bed differs from pull request most recent head fac3c9b. Consider uploading reports for the commit fac3c9b to get more accurate results

@@           Coverage Diff           @@
##           master   #9481    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         180     180            
  Lines       15066   15066            
=======================================
- Hits        13986   13373   -613     
- Misses       1080    1693   +613     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dope !

Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small comment

tests/utilities/test_auto_restart.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Sep 13, 2021
@awaelchli awaelchli enabled auto-merge (squash) September 13, 2021 12:06
@awaelchli awaelchli merged commit dddd3e9 into master Sep 13, 2021
@awaelchli awaelchli deleted the tests/ft-test-resumed-weights branch September 13, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants