Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Make the bot less aggressive #9575

Merged
merged 4 commits into from Sep 17, 2021
Merged

[CI] Make the bot less aggressive #9575

merged 4 commits into from Sep 17, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Sep 17, 2021 •
edited by Borda

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@tchaton tchaton self-assigned this Sep 17, 2021
@tchaton tchaton added this to the v1.5 milestone Sep 17, 2021
@tchaton tchaton added this to In progress in Sprint Q3-6: 6 Sep - 17 Sep via automation Sep 17, 2021
@tchaton tchaton added the ci Continuous Integration label Sep 17, 2021
@codecov
Copy link

codecov bot commented Sep 17, 2021 •
edited

Codecov Report

Merging #9575 (ecc0373) into master (45200fc) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #9575   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         180     181    +1     
  Lines       15116   15159   +43     
======================================
+ Hits        14043   14084   +41     
- Misses       1073    1075    +2

@mergify mergify bot added the ready PRs ready to be merged label Sep 17, 2021
@mergify mergify bot requested a review from a team September 17, 2021 08:48
@mergify mergify bot requested a review from a team September 17, 2021 08:51
@tchaton @Borda
Update .github/workflows/ci_verify_pr_contains_issue.yaml
ecc0373 
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
@tchaton tchaton enabled auto-merge (squash) September 17, 2021 14:38
@tchaton tchaton merged commit 10d8031 into master Sep 17, 2021
Sprint Q3-6: 6 Sep - 17 Sep automation moved this from In progress to Done Sep 17, 2021
@tchaton tchaton deleted the test branch September 17, 2021 15:33
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

5 similar comments
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

2 similar comments
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@Borda
Copy link
Member

Borda commented Sep 17, 2021

seems something went wrong...
image

SeanNaren pushed a commit that referenced this pull request Sep 22, 2021
@tchaton @Borda
[CI] Make the bot less aggressive (#9575)
401ed8d 
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
@akihironitta akihironitta mentioned this pull request Oct 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@SeanNaren SeanNaren SeanNaren approved these changes

@justusschock justusschock justusschock approved these changes

@carmocca carmocca Awaiting requested review from carmocca carmocca is a code owner

Assignees

@tchaton tchaton

Labels
ci Continuous Integration ready PRs ready to be merged
Projects
No open projects
Sprint Q3-6: 6 Sep - 17 Sep
  
Done
Milestone
pl:1.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tchaton @Borda @awaelchli @SeanNaren @justusschock