Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Shorthand notation to instantiate models #9588

Merged
merged 6 commits into from Sep 22, 2021

Conversation

carmocca
Copy link
Member

@carmocca carmocca commented Sep 18, 2021

What does this PR do?

Part of #7250

See docs changes for more context

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added feature Is an improvement or enhancement argparse (removed) Related to argument parsing (argparse, Hydra, ...) labels Sep 18, 2021
@carmocca carmocca added this to the v1.5 milestone Sep 18, 2021
@carmocca carmocca self-assigned this Sep 18, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT ! Really excited about this feature !

Base automatically changed from bugfix/cli-registry-decorator to master September 21, 2021 13:24
@carmocca carmocca marked this pull request as ready for review September 21, 2021 13:25
@mergify mergify bot removed the has conflicts label Sep 21, 2021
@mergify mergify bot added the ready PRs ready to be merged label Sep 22, 2021
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tchaton tchaton enabled auto-merge (squash) September 22, 2021 12:17
@carmocca carmocca enabled auto-merge (squash) September 22, 2021 12:43
@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #9588 (e9ce94f) into master (e64f358) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9588    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         179     179            
  Lines       15317   15321     +4     
=======================================
- Hits        14209   13594   -615     
- Misses       1108    1727   +619     

@carmocca carmocca merged commit 3f7872d into master Sep 22, 2021
@carmocca carmocca deleted the feat/cli-shorthand-model branch September 22, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argparse (removed) Related to argument parsing (argparse, Hydra, ...) feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants