Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

del iterator on_run_end() #9915

Merged
merged 33 commits into from Oct 29, 2021
Merged

del iterator on_run_end() #9915

merged 33 commits into from Oct 29, 2021
+63 −10

Conversation

cowwoc
Copy link
Contributor

@cowwoc cowwoc commented Oct 13, 2021 •
edited

What does this PR do?

Fixes #9390

Does your PR introduce any breaking changes? If yes, please list them.

No

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@cowwoc cowwoc changed the title Del iterators del iterator on_run_end() Oct 13, 2021
@cowwoc cowwoc mentioned this pull request Oct 13, 2021
Closed
@codecov
Copy link

codecov bot commented Oct 13, 2021 •
edited

Codecov Report

Merging #9915 (257eb3a) into master (808edcd) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #9915   +/-   ##
======================================
- Coverage      89%     89%   -0%     
======================================
  Files         180     180           
  Lines       16147   16188   +41     
======================================
+ Hits        14318   14335   +17     
- Misses       1829    1853   +24

@cowwoc
Copy link
Contributor Author

cowwoc commented Oct 13, 2021

Can someone please re-run the failing build? I don't have permission to.

@awaelchli awaelchli added bug Something isn't working priority: 0 High priority task labels Oct 13, 2021
@awaelchli awaelchli modified the milestones: v1.4.x, v1.5 Oct 13, 2021
tchaton
tchaton approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Oct 14, 2021
@mergify mergify bot removed the has conflicts label Oct 25, 2021
carmocca
carmocca reviewed Oct 25, 2021
View reviewed changes
Copy link
Member

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed back the test as we want to make sure we shutdown the workers.

pytorch_lightning/utilities/fetching.py Outdated Show resolved Hide resolved
pytorch_lightning/loops/fit_loop.py Outdated Show resolved Hide resolved
pytorch_lightning/loops/epoch/training_epoch_loop.py Outdated Show resolved Hide resolved
@tchaton
Copy link
Contributor

tchaton commented Oct 26, 2021

@carmocca Should we kill the workers only on the latest epoch ?

@cowwoc
Copy link
Contributor Author

cowwoc commented Oct 26, 2021

(Be sure to clean up even if training/inference is aborted due to an exception)

carmocca
carmocca approved these changes Oct 27, 2021
View reviewed changes
pytorch_lightning/utilities/fetching.py Outdated Show resolved Hide resolved
tests/loops/test_training_loop.py Outdated Show resolved Hide resolved
@tchaton tchaton enabled auto-merge (squash) October 29, 2021 12:44
@tchaton tchaton merged commit a967b6e into Lightning-AI:master Oct 29, 2021
@cowwoc cowwoc deleted the del-iterators branch October 29, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaton tchaton tchaton approved these changes

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca carmocca approved these changes

@justusschock justusschock Awaiting requested review from justusschock

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@tchaton tchaton

Labels
bug Something isn't working priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.5
Development

Successfully merging this pull request may close these issues.

Ability to release resources associated with a DataLoader
4 participants
@cowwoc @tchaton @awaelchli @carmocca