Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The bot doesn't work with the new fee structure. #38

Open
kinbitz opened this issue Feb 22, 2022 · 2 comments
Open

The bot doesn't work with the new fee structure. #38

kinbitz opened this issue Feb 22, 2022 · 2 comments

Comments

@kinbitz
Copy link
Contributor

kinbitz commented Feb 22, 2022

Need to add the wxFeeCalculator = pw.WXFeeCalculator() function to calculate the new fee.

@hansklepitko
Copy link

hansklepitko commented Apr 9, 2022

The Code of that bot would need quite a bit of tweaking to work properly again.
We are using it mostly to learn about PyWaves and WavesExchange. It is educational material for us, and we'd love to see it work properly.

@kinbitz, I like your contribution, however, we will have a problem with line 50 of your fork:

if sell_balance > tranche_size: o = BLACKBOT.sell(PAIR, tranche_size, price, maxLifetime=ORDER_LIFETIME, matcherFee=ORDER_FEE)

It still grabs an old ORDER_FEE config and on the attempt of creating a sell order in the grid, it throws an error.
I tried to fix it but haven't managed yet.

In the example of the WX-USDN pair, I changed line 47 a little to pay a fee in WX instead of USDN:
(placing a buy grid order works fine)

Replaced:
matcherFeeAssetId=priceAssetID

To:
matcherFeeAssetId=amountAssetID

Are you able to help fix the fee calculation for the sale orders in your fork? Thanks

@kinbitz
Copy link
Contributor Author

kinbitz commented Jun 24, 2022

I am using it on the WAVES-USDN pair and it somehow works, not sure why. Perhaps try to calculate the correct fee using matcher_Fee = wxFeeCalculator.calculatePercentDiscountedBuyingFee(priceAssetID, price, tranche_size).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants