Skip to content
This repository has been archived by the owner on Feb 12, 2023. It is now read-only.

Make wavelink a pycord extension #15

Closed
Luc1412 opened this issue Jan 8, 2022 · 4 comments
Closed

Make wavelink a pycord extension #15

Luc1412 opened this issue Jan 8, 2022 · 4 comments

Comments

@Luc1412
Copy link

Luc1412 commented Jan 8, 2022

I think a smart implementation of this library would be as an extension by moving it into the discord/ext/wavelink namespace.

Also the library name currently is a bit unconventional. pycord-ext-wavelink or py-cord-ext-wavelink would be better by following the naming conventions from Danny (menu extension)

@VincentRPS
Copy link
Member

VincentRPS commented Jan 13, 2022

As Pycord.Wavelink is under another license it would have to be remade to work with our current license.

@Luc1412
Copy link
Author

Luc1412 commented Jan 13, 2022

As Pycord.Wavelink is under another license it would have to be remade to work with our current license.

Are you sure it needs another license? I don't intend to merge it into the pycord repo. Just the directory and pipy name should be changed accordingly to my issue.

@VincentRPS
Copy link
Member

As Pycord.Wavelink is under another license it would have to be remade to work with our current license.

Are you sure it needs another license? I don't intend to merge it into the pycord repo. Just the directory and pipy name should be changed accordingly to my issue.

wdym?

@Luc1412
Copy link
Author

Luc1412 commented Jan 13, 2022

wdym?

Here a good example from Danny: https://github.com/Rapptz/discord-ext-menus
Extensions doesn't need to be placed in the same repo as the extendable library itself.

@Luc1412 Luc1412 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants