Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated audioop implementation of PCMVolumeTransformer.read #2177

Open
davidhozic opened this issue Jul 23, 2023 · 0 comments · May be fixed by #2176
Open

Replace deprecated audioop implementation of PCMVolumeTransformer.read #2177

davidhozic opened this issue Jul 23, 2023 · 0 comments · May be fixed by #2176
Labels
feature request New feature request on hold

Comments

@davidhozic
Copy link
Contributor

davidhozic commented Jul 23, 2023 •
edited

Summary

Replaces PCMVolumeTransformer.read implementation.

Closes #2176.

What is the feature request for?

The core library

The Problem

The built-in Python library audioop will be removed in Python 3.13 and it is deprecated since Python 3.11.
PCMVolumeTransformer.read() uses this module to do multiplications on bytes.

The Ideal Solution

Replace PCMVolumeTransformer.read() with a pure Python equivalent.

The Current Solution

PCMVolumeTransformer.read() uses the audioop.mul to multiply with volume.

Additional Context

No response
@davidhozic davidhozic added the feature request New feature request label Jul 23, 2023
@davidhozic davidhozic linked a pull request Jul 23, 2023 that will close this issue
Open
9 tasks
@Lulalaby Lulalaby linked a pull request Jul 23, 2023 that will close this issue
refactor: python implementation of audioop.mul #2176
Open
9 tasks
@Dorukyum Dorukyum removed the on hold label Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature request on hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: python implementation of audioop.mul davidhozic/pycord
3 participants
@Lulalaby @davidhozic @Dorukyum