Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slash options broken when declared explicitly #2332

Merged
merged 3 commits into from Jan 28, 2024

Conversation

plun1331
Copy link
Member

Summary

Fixes command options being dysfunctional when declared through decorators or the options kwarg in SlashCommand

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Lulalaby
Lulalaby previously approved these changes Jan 28, 2024
@plun1331 plun1331 enabled auto-merge (squash) January 28, 2024 01:37
@plun1331 plun1331 added bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer labels Jan 28, 2024
@plun1331 plun1331 added this to the v2.5 milestone Jan 28, 2024
@plun1331 plun1331 self-assigned this Jan 28, 2024
@plun1331 plun1331 merged commit f0c33dd into Pycord-Development:master Jan 28, 2024
29 checks passed
@plun1331 plun1331 deleted the fix-app-cmd-opts branch January 28, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants