Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Duplication in bridge command help #2415

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

fix: Duplication in bridge command help #2415

wants to merge 10 commits into from

Conversation

Blue-Robin-Taken
Copy link
Contributor

Summary

This pull request is for the issue #2306

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Blue-Robin-Taken Blue-Robin-Taken requested a review from a team as a code owner April 5, 2024 13:06
@Blue-Robin-Taken Blue-Robin-Taken marked this pull request as draft April 5, 2024 13:06
@pullapprove4 pullapprove4 bot requested a review from BobDotCom April 5, 2024 13:06
@Blue-Robin-Taken
Update CHANGELOG.md
270bf96 
Signed-off-by: BlueRobin <julianjohnt@Gmail.com>
@Blue-Robin-Taken Blue-Robin-Taken marked this pull request as ready for review April 5, 2024 15:37
Lulalaby
Lulalaby previously approved these changes Apr 6, 2024
View reviewed changes
@Lulalaby Lulalaby enabled auto-merge (squash) April 6, 2024 17:22
@Lulalaby Lulalaby requested review from Dorukyum and JustaSqu1d and removed request for BobDotCom April 6, 2024 17:23
JustaSqu1d
JustaSqu1d suggested changes Apr 9, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
discord/ext/commands/help.py Outdated Show resolved Hide resolved
@Blue-Robin-Taken
Use case for same group
f4c943f 
Signed-off-by: BlueRobin <julianjohnt@Gmail.com>
auto-merge was automatically disabled April 9, 2024 20:22

Head branch was pushed to by a user without write access

Blue-Robin-Taken and others added 3 commits April 9, 2024 15:22
@Blue-Robin-Taken @JustaSqu1d
Update CHANGELOG.md
f9146ba 
Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com>
Signed-off-by: BlueRobin <julianjohnt@Gmail.com>
@Blue-Robin-Taken
Merge branch 'master' into master
b374dc1 
Signed-off-by: BlueRobin <julianjohnt@Gmail.com>
@pre-commit-ci
style(pre-commit): auto fixes from pre-commit.com hooks
a730a69
@Blue-Robin-Taken
Copy link
Contributor Author

I haven't checked if the code works yet but I will when I get home

@plun1331 plun1331 linked an issue Apr 12, 2024 that may be closed by this pull request
Command duplication in cog help #2306
Open
3 tasks
@plun1331 plun1331 added the bug Something isn't working label Apr 12, 2024
@plun1331
Copy link
Member

plun1331 commented May 6, 2024

I haven't checked if the code works yet but I will when I get home

Any updates?

@Blue-Robin-Taken
Copy link
Contributor Author

Blue-Robin-Taken commented May 6, 2024 •
edited

Thanks for the reminder, I currently do not have time atm to check it still 💀
finals are coming up and I might be able to check tomorrow

sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

@JustaSqu1d JustaSqu1d Awaiting requested review from JustaSqu1d

@Lulalaby Lulalaby Awaiting requested review from Lulalaby

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working PA: All Contributors pending PA: Maintainers pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Command duplication in cog help
4 participants
@Blue-Robin-Taken @plun1331 @Lulalaby @JustaSqu1d