Add description attribute to Attachment

[plun1331]

Summary

Adds the description attribute to Attachment

This can also be added to File, but I tried and couldn't get it to work

Resolves #483 (I guess)

Checklist

• If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
• If type: ignore comments were used, a comment is also left explaining why
• This PR fixes an issue.
• This PR adds something new (e.g. new method or parameters).
• This PR is a breaking change (e.g. methods or parameters removed/renamed)
• This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

[Lulalaby]

Yep that's correct ❤️

[Lulalaby]

I'm a bit tired rn and on phone. Did you added description to adding files too?
If you send a message with a file you can add the description. The topic is a bit difficult.

[Lulalaby]

If not, we can merge this so bots can already access the property.

[plun1331]

I'm a bit tired rn and on phone. Did you added description to adding files too? If you send a message with a file you can add the description. The topic is a bit difficult.

i spent a few hours trying but discord seems to dislike me
but no, i didn't

[Lulalaby]

I'm a bit tired rn and on phone. Did you added description to adding files too? If you send a message with a file you can add the description. The topic is a bit difficult.

i spent a few hours trying but discord seems to dislike me
but no, i didn't

Ok I'm gonna make a new issue for that with additional informations.

[Lulalaby]

@plun1331 if you're interested how it would work, you could take a look here: Aiko-IT-Systems/DisCatSharp#81

Not many libs has it implemented yet. Discord sneaked it into the docs without any notice :D

[plun1331]

@plun1331 if you're interested how it would work, you could take a look here: Aiko-IT-Systems/DisCatSharp#81

Not many libs has it implemented yet. Discord sneaked it into the docs without any notice :D

I tried to implement it in a fork but discord kept sending me 400s and I couldn't figure out why

[Lulalaby]

{
   "code":50035,
   "errors":{
      "attachments":{
         "0":{
            "_errors":[
               {
                  "code":"ATTACHMENT_NOT_FOUND",
                  "message":"Attachment data not found"
               }
            ]
         }
      },
      "message":"Invalid Form Body"
   }
}

Is that the error you get

[Lulalaby]

A correct payload_json would be:

{
   "tts":false,
   "allowed_mentions":{
      "parse":[
         "everyone",
         "users",
         "roles"
      ]
   },
   "attachments":[
      {
         "filename":"cute.jpg",
         "description":"Cute anime girl UwU",
         "size":0,
         "id":0
      }
   ]
}

And the files name in the file form-data has to be files[0] in this case.
files[n] must be mapped to attachments: [{ "id": n }]

[plun1331]

A correct payload_json would be:

{
   "tts":false,
   "allowed_mentions":{
      "parse":[
         "everyone",
         "users",
         "roles"
      ]
   },
   "attachments":[
      {
         "filename":"cute.jpg",
         "description":"Cute anime girl UwU",
         "size":0,
         "id":0
      }
   ]
}

And the files name in the file form-data has to be files[0] in this case. files[n] must be mapped to attachments: [{ "id": n }]

iirc thats what i was sending, but ill check

[Lulalaby]

Check if the file names are really files[n] and not encoded

[plun1331]

threw in a print and it's claiming this is being sent

[
  (<MultiDict('name': 'payload_json')>, 
  {}, 
  '{"tts":null,"content":"a","message_reference":{"message_id":913294318368862249,"channel_id":889181570932551692,"guild_id":889181570932551690},"attachments":[{"id":0,"description":"Profile banner","filename":"banner.jpg"}]}'), 
  (<MultiDict('name': 'files[0]', 'filename': 'banner.jpg')>, 
  {'Content-Type': 'application/octet-stream'}, 
  <_io.BufferedReader name='banner.jpg'>)
]

[plun1331]

Wrong content type

thats what the lib set it to originally, what should it be set to

[Lulalaby]

No the media content type is wrong. It should be image/jpeg

[plun1331]

application/form-data

for the file?
also, could we continue this on discord

[Lulalaby]

The media content type headers are an evil topic

[Lulalaby]

application/form-data

for the file?
also, could we continue this on discord

Yus let's do that

Pending

[plun1331]

Continued in #509