Option Redesign (fix for #513)

[EmreTech]

Summary

This PR fixes #513 by redesigning how Options are set. This also documents the Option class.

TODO List for this PR to be merged:

• Update the option decorator to reflect how Options are set now
• Fix options defined in the slash_command kwarg
• Document Option

Checklist

• If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
• If type: ignore comments were used, a comment is also left explaining why
• This PR fixes an issue.
• This PR adds something new (e.g. new method or parameters).
• This PR is a breaking change (e.g. methods or parameters removed/renamed)
• This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

[Lulalaby]

@EmreTech what's the current state of this

[EmreTech]

@EmreTech what's the current state of this

I've tested it, and it should be done now. I'm just waiting for reviews.

[Middledot]

This seems to break if parentheses are in the option description.

@client.slash_command()
async def dis_is_test(ctx, channel: discord.Option(discord.TextChannel, description="Is a channel? (yes)")):
    await ctx.respond(channel.mention)

Value that is passed into gettype: TextChannel, description='Is a channel? (yes)' instead of only TextChannel

[EmreTech]

This seems to break if parentheses are in the option description.

@client.slash_command()
async def dis_is_test(ctx, channel: discord.Option(discord.TextChannel, description="Is a channel? (yes)")):
    await ctx.respond(channel.mention)

Value that is passed into gettype: TextChannel, description='Is a channel? (yes)' instead of only TextChannel

Working on it, thanks for telling me

[EmreTech]

This seems to break if parentheses are in the option description.

@client.slash_command()
async def dis_is_test(ctx, channel: discord.Option(discord.TextChannel, description="Is a channel? (yes)")):
    await ctx.respond(channel.mention)

Value that is passed into gettype: TextChannel, description='Is a channel? (yes)' instead of only TextChannel

Done.

[Lulalaby]

Holy fuck, this got big.
Gonna review over the day.

[Lulalaby]

Closing in favor of #1251.
Core team decision.

[EmreTech]

I'll do some code fixes and try to improve this PR

[Lulalaby]

We reviewed this pr internally and its too messy rn and wasnt in progress for a week / longer.
Clone will complete this within the next days.

Sorry, but this is the end decision for now.

[Lulalaby]

2 months is just too long