This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Delete discussion embed when entry is deleted #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankith26
suggested changes
Jun 11, 2021
|
This PR is looking good, but I have left a review for a few changes that could be done. |
|
I have removed the import and added the edit feature. |
ankith26
suggested changes
Jun 11, 2021
|
Is it fine now? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps in keeping the discussion channel clean when someone accidently sends something in resource or showcase.
Right now it deletes the embed but maybe editing the embed to say the original message has been deleted would've been better.
Also, for some reason, black has added an import statement in line 19. I don't know if its necessary.