Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with third party boards from adafruit #3

Closed
Nep-Soundfont opened this issue Jul 15, 2019 · 5 comments
Closed

issue with third party boards from adafruit #3

Nep-Soundfont opened this issue Jul 15, 2019 · 5 comments

Comments

@Nep-Soundfont
Copy link

Arduino bare minimum sketch fails to compile successfully on adafruit boards, most likely due to the board definition doesn't exist properly. if this can't be fixed, please make a circuitpython library for those with circuitpython boards like me.
anyway, the log usually states this:

 void setup(HardwareSerial &serial_ref = Serial, String deviceName = BOARD);

                                         ^
@Nep-Soundfont
Copy link
Author

Nep-Soundfont commented Jul 15, 2019

actually ive only tried the feather M0 Express board, i'm sure it's the same for other boards though

@KlemenDEV
Copy link
Contributor

This library is not intended to be used with CircuitPython, but with normal Arduino IDE. We don't plan to implement support for this at the moment as we do not have hardware for testing, but if anyone is interested in doing this, we can reopen this ticket and accept the pull request.

@Nep-Soundfont
Copy link
Author

error log
like i said: i have errors with uploading the bare minimum sketch from the arduino IDE to an adafruit feather M0 express. contrary to that, i also tried an arduino uno and it works just fine, i'm getting compiler errors with a third party arduino compatible not listed in boardnames.h

@Nep-Soundfont
Copy link
Author

this is what i get with the same board while compiling the bareminimum2 sketch
C:\Users\Nep Soundfont\Documents\ArduinoData\packages\adafruit\hardware\samd\1.5.2\variants\feather_m0_express/variant.h:240:37: error: could not convert 'Serial' from 'Serial_' to 'HardwareSerial&'

#define SERIAL_PORT_MONITOR Serial

                                 ^

C:\Users\Nep Soundfont\Documents\Arduino\libraries\Minecraft_Link\src/MinecraftLink.h:54:45: note: in expansion of macro 'SERIAL_PORT_MONITOR'

 void setup(HardwareSerial &serial_ref = SERIAL_PORT_MONITOR, String deviceName = BOARD);

                                         ^

C:\Users\Nep Soundfont\Documents\Arduino\libraries\Minecraft_Link\examples\BareMinimum2\BareMinimum2.ino: In function 'void setup()':

BareMinimum2:5:46: error: no matching function for call to 'MinecraftLinkImpl::setup(Serial_&, const char [12])'

 MinecraftLink.setup(Serial, "Device Name");

                                          ^

C:\Users\Nep Soundfont\Documents\Arduino\libraries\Minecraft_Link\examples\BareMinimum2\BareMinimum2.ino:5:46: note: candidate is:

In file included from C:\Users\Nep Soundfont\Documents\Arduino\libraries\Minecraft_Link\examples\BareMinimum2\BareMinimum2.ino:1:0:

C:\Users\Nep Soundfont\Documents\Arduino\libraries\Minecraft_Link\src/MinecraftLink.h:54:10: note: void MinecraftLinkImpl::setup(HardwareSerial&, String)

 void setup(HardwareSerial &serial_ref = SERIAL_PORT_MONITOR, String deviceName = BOARD);

      ^

C:\Users\Nep Soundfont\Documents\Arduino\libraries\Minecraft_Link\src/MinecraftLink.h:54:10: note: no known conversion for argument 1 from 'Serial_' to 'HardwareSerial&'

exit status 1
no matching function for call to 'MinecraftLinkImpl::setup(Serial_&, const char [12])'
looks approximately the same, but it's different

@KlemenDEV KlemenDEV reopened this Jul 24, 2019
@KlemenDEV
Copy link
Contributor

We have fixed this issue in Minecraft Link for Arduino 1.1.0. The update in the library manager should be available soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants