Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous module loading broken #150

Closed
ztane opened this issue Mar 20, 2014 · 4 comments
Closed

Asynchronous module loading broken #150

ztane opened this issue Mar 20, 2014 · 4 comments

Comments

@ztane
Copy link

ztane commented Mar 20, 2014

toolbar.js does not use define(...) framing, nor does it seem to list jquery as a requisite by any other means, even though it requires jquery.

This is never right, if it works, you met a heisenbug. On Firefox it causes

ReferenceError jQuery is not defined jQuery(document).ready(function($) { toolbar.js (line 16)

@ztane ztane changed the title AM Asynchronous module loading broken Mar 20, 2014
@inklesspen
Copy link
Contributor

@stevepiercy
Copy link
Member

@ztane please try now with the latest debugtoolbar and report back your results.

@inklesspen A link without an explanation of purpose leaves much to interpretation. Please be more explicit with your intent and to whom it is directed.

Thank you!

@inklesspen
Copy link
Contributor

@stevepiercy my apologies. I had a disagreement with @ztane on the IRC channel about some part of this (which I no longer remember) and I added the url as enlightenment.

It's no longer very enlightening to me, so.

@mmerickel
Copy link
Member

Closing this as it shouldn't be an issue in 2.x. Report back if it should be reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants