Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] cannot pick up any amber chunks #278

Closed
invisiblehsadow opened this issue Dec 2, 2021 · 10 comments
Closed

[Bug report] cannot pick up any amber chunks #278

invisiblehsadow opened this issue Dec 2, 2021 · 10 comments
Assignees
Labels
bug Something isn't working fixed in code or data Fixed in code/data but not released yet
Milestone

Comments

@invisiblehsadow
Copy link

in the mine on the forest moon you cannot pick up any amber chunks from the ground. they are shown on the map, but even vady (looking for treasures at value 95) cannot record them. no matter whether you walk over it or press examine. There are several places in the mines where pieces of amber lie on the ground and this bug is everywhere.
Screenshot_01-12-2021 18-58-20
Screenshot_01-12-2021 18-58-22
Screenshot_01-12-2021 19-01-53

@invisiblehsadow invisiblehsadow added the bug Something isn't working label Dec 2, 2021
@Pyrdacor Pyrdacor added the v1.4 Ambermoon.net 1.4 label Dec 2, 2021
@Pyrdacor Pyrdacor added this to the Ambermoon 1.4 milestone Dec 2, 2021
@Pyrdacor Pyrdacor changed the title cannot pick up any amber chunks [Bug report] cannot pick up any amber chunks Dec 2, 2021
@Pyrdacor Pyrdacor added this to Low priority in Ambermoon fixes and enhancements Dec 3, 2021
@Pyrdacor Pyrdacor moved this from Low priority to Quick fixes in Ambermoon fixes and enhancements Dec 3, 2021
@Pyrdacor Pyrdacor moved this from Quick fixes to WIP in Ambermoon fixes and enhancements Dec 4, 2021
@Pyrdacor
Copy link
Owner

Pyrdacor commented Dec 4, 2021

Hm I can pick the amber up without problems by using the eye cursor. Moving onto them works too.

@Pyrdacor Pyrdacor added the pending reproduction Needs further input/testing/reproduction by the issuer label Dec 4, 2021
@Pyrdacor Pyrdacor moved this from WIP to Pending reproduction in Ambermoon fixes and enhancements Dec 4, 2021
@invisiblehsadow
Copy link
Author

the only thing I did "special" was to use the noclip function beforehand to get to the important points, maybe that has an influence? if not, it was a coincidence. after you have ended the gadlons you have to run up through the mines again, there was the bug again.

@Pyrdacor
Copy link
Owner

Pyrdacor commented Dec 5, 2021

Can you please test the following:

  • Start a brand new game
  • Teleport to Mine at 20, 14
  • Try to pick up the amber

@invisiblehsadow
Copy link
Author

invisiblehsadow commented Dec 8, 2021

it works :)
Screenshot_08-12-2021 07-39-27
Screenshot_08-12-2021 07-39-53

@Pyrdacor
Copy link
Owner

Pyrdacor commented Dec 8, 2021

I guess your savegame got somehow corrupted.

@Pyrdacor Pyrdacor closed this as completed Dec 8, 2021
Ambermoon fixes and enhancements automation moved this from Pending reproduction to Closed Dec 8, 2021
@iancrossfield
Copy link

Though this Issue was closed, I can reproduce it in my game. I could post screenshots but they would be exactly the same as those of @invisiblehsadow above (except mine are in English). None of my 6 characters can pick up the amber chunks in the Mine location shown above -- whether by walking over the chunk, or clicking the eyeball or hand buttons. The same behavior occurs in both Ambermoon.net Version 1.1 (where I've been playing) and Version 1.3 (I copied the save-game directory into a new download) -- both games were run under Linux.

@Pyrdacor , I don't know how to teleport (per your advice above, to "Teleport to Mine at 20, 14") so I'm not sure how to test this or otherwise make headway... Any suggestions? or should I just wait until v1.4 ?

@Pyrdacor
Copy link
Owner

The issue seemed to be related to the savegame. I guess it was broken in an older Ambermoon release somehow. It worked for @invisiblehsadow with a fresh new game.

If you send me your savegame I can check if it is broken.

The teleport cheat can be used from the console. But before 1.4, this will only work if you won't start the game from a terminal/bash/shell. Then there should be an additional console window (at least on Windows, I can only hope that it only is shown in Linux). If you then enable cheats in the options, you can use the teleport cheat inside that console window. In 1.4 you will be able to do this in the terminal as well if you started the game from there. 1.4 will be there in a very short time. Very short. :D

@iancrossfield
Copy link

Yes, I still can't pick up the Amber bits even in v1.4. The cheat console does work
at the Linux command line, and I can successfully give myself Amber chunks
'manually' with that.

Just in case you wanted to look at them, my Saves directory is attached.
Saves.tar.gz

Looking forward to finishing the game (though I came to the Green Jewel way too underpowered!). Thanks as always.

@Pyrdacor
Copy link
Owner

Pyrdacor commented Jan 2, 2022

Thanks. I will look at the save soon. If you have time for it, maybe you can start a new game, teleport (with cheat) to the spot with the amber and try to pick it up then.

You can use maps Mine to see the map index. Then use teleport <mapid> 20 14.

@Pyrdacor
Copy link
Owner

I had a bit time to investigate this and finally found the cause. In Ambermoon chest content is stored in Chest_data.amb. The Amber pieces are chests as well. A chest with one item. For normal chests where you can also store stuff, each real ingame chest has one data chest in Chest_data.amb. But for single item pickups like the Amber the data entry in Chest_data.amb is re-used multiple time. Each piece of Amber shares the chest data. But in general when you change the content of a chest by removing or adding items, the chest data is changed accordingly. This was the same for the Amber. So when you picked up an Amber anywhere, the associated chest data was emptied. And when you approach another Amber, as the chest is "empty", it won't show anything and not even open the loot window.

I changed that. When you empty a pickup chest, it refills the chest data to the initial state. So the next Amber "chest" will contain an Amber again.

I tested it. Without the change after the first pickup, all other Amber pieces can't be picked up. But now as I fixed it, it works. Unfortunately this won't repair savegames that are already affected as the chest data is empty there already.

The fix will be part of the upcoming 1.5.2 patch release.

@Pyrdacor Pyrdacor modified the milestones: Ambermoon 1.4, Ambermoon 1.6 May 16, 2022
@Pyrdacor Pyrdacor added fixed in code or data Fixed in code/data but not released yet and removed pending reproduction Needs further input/testing/reproduction by the issuer v1.4 Ambermoon.net 1.4 labels May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in code or data Fixed in code/data but not released yet
Development

No branches or pull requests

3 participants