Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Side-specific border coloring with .xml values does not work #47

Open
Felipe-Caldeira opened this issue Feb 20, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@Felipe-Caldeira
Copy link

Describe the bug

Side-specific border coloring when making the UI with .xml does not work properly.

To Reproduce

Steps to reproduce the behavior:

  1. Create a simple Basalt UI with .xml style
  2. Add an object with a side-specific border coloring:
<button x="2" y="2" text="Hello" borderBottom="blue" />
  1. Run the program
  2. See error:
    Basalt error: .../basaltDraw.lua:202: bad argument (string expected, got nil)

Expected behavior

A button with the text "Hello" should appear with a blue border only along the bottom

Additional context

Changing these four lines (138-141) in Object.lua seems to fix it! Just had to wrap the xmlValue(...) return with colors[...], like the other surrounding code does.

if(xmlValue("borderLeft", data)~=nil)then borderColors["left"] = colors[xmlValue("borderLeft", data)] end
if(xmlValue("borderTop", data)~=nil)then borderColors["top"] = colors[xmlValue("borderTop", data)] end
if(xmlValue("borderRight", data)~=nil)then borderColors["right"] = colors[xmlValue("borderRight", data)] end
if(xmlValue("borderBottom", data)~=nil)then borderColors["bottom"] = colors[xmlValue("borderBottom", data)] end

Checklist

[x] I am running the latest version.
Tick the box if you are running the latest version!

@Felipe-Caldeira Felipe-Caldeira added the bug Something isn't working label Feb 20, 2023
@NoryiE
Copy link
Collaborator

NoryiE commented Feb 20, 2023

Hello! Thank you very much - also thanks for fixing it yourself and providing me the code! This issue got fixed in 6f0ddd6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants