Strings Have A 2 (Or More) Byte Type Overhead

[SolarScuffle-Bot]

https://data-oriented-house.github.io/Squash/docs/binary#strings

I realize the code is a simple #string + 2, though the initial TYPE_OVERHEAD variable made it seem like every type only has 1 byte of overhead. Also much like with remote functions, the number of size bytes changes when the value reaches 0x80 (128 characters) because it uses a Variable Length Quantity (VLQ) encoding scheme

[Pyseph]

If I'm understanding correctly, the#String + 2 should instead be #String + math.ceil(#String / 128) (type overhead being added afterwards; I'll update GetDataByteSize to append the type overhead also) - would this be the intended behavior? I'll take a further look tomorrow.

[SolarScuffle-Bot]

I believe the calculation would be math.ceil(math.log(#string + 1, 128)).

[Pyseph]

The above calculation wouldn't work when #string == 0, as the output would be 0; which I assume isn't the correct behavior. I've implemented the following function:

local function GetVLQSize(InitialSize: number, Length: number)
	return math.max(math.ceil(math.log(Length + InitialSize, 128)), InitialSize)
end