Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move defined block list to init #730

Closed
facelessuser opened this issue Oct 9, 2018 · 1 comment
Closed

Move defined block list to init #730

facelessuser opened this issue Oct 9, 2018 · 1 comment
Assignees

Comments

@facelessuser
Copy link
Collaborator

I believe we should move the block HTML list to the class init https://github.com/Python-Markdown/markdown/blob/master/markdown/core.py#L55.

I believe much like the escaped character list, if plugins take advantage of this, it will modify the base class instead of the class instance.

I'm opening this issue to allow disagreement with this before I do the work.

@facelessuser facelessuser changed the title Move defined block hello to init Move defined block list to init Oct 9, 2018
@waylan
Copy link
Member

waylan commented Oct 9, 2018

I believe much like the escaped character list, if plugins take advantage of this, it will modify the base class instead of the class instance.

You are correct. This could be a problem in multi-treadled environments, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants